MusicXML export: Make rests before making notation #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Aug 7, 2022
Comment on lines
-1682
to
-1688
| >>> v = stream.Voice(note.Note()) | ||
| >>> m = stream.Measure([meter.TimeSignature(), v]) | ||
| >>> GEX = musicxml.m21ToXml.GeneralObjectExporter(m) | ||
| >>> out = GEX.parse() # out is bytes | ||
| >>> outStr = out.decode('utf-8') # now is string | ||
| >>> '<note print-object="no" print-spacing="yes">' in outStr | ||
| True |
There was a problem hiding this comment.
This test is moved to fromGeneralObject() doctest
Comment on lines
+422
to
+423
| # workaround until getET() helper starts calling fromGeneralObject | ||
| s = GeneralObjectExporter().fromGeneralObject(s) |
There was a problem hiding this comment.
We really need to get all the musicxml tests to declare whether or not they depend on notation being made. This was a problem before we added makeNotation=False as an option -- essentially, getET() bypasses part of the normal musicxml export path.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1242. Didn't quite fix #904 because we need to make rests before making notation (if we are to have the opportunity to re-express the rests inside tuplets).